Add Dockerfile highlighting support #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendt
reviewed
Aug 3, 2024
| { | ||
| public function getName(): string | ||
| { | ||
| return 'Dockerfile'; |
There was a problem hiding this comment.
Should this be dockerfile? Maybe add docker as an alias as well?
There was a problem hiding this comment.
I had the same thought as you regarding the alias. And ChatGPT would also describe it this way, so I think dockerfile and docker will be enough.
|
Let me know your thoughts about that one comment, otherwise I'm good merging it 👍 |
Pull Request Test Coverage Report for Build 10227678571Details
💛 - Coveralls |
kburton-dev
force-pushed
the
add-dockerfile-support
branch
from
46721e7
to
cd9156b
Compare
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on keywords listed here: https://docs.docker.com/reference/dockerfile/#overview
With support for
ASkeyword when aliasing image names, and highlighting image names and tags: