Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode tokens in standardizing line endings #143

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

nimah79
Copy link
Contributor

@nimah79 nimah79 commented Aug 26, 2024

This PR fixes rendering codes that contain UTF-8 tokens when using gutter or Ellison. For example, the following code is not currently being rendered correctly:

import نام کتابخانه

The highlighted output is currently something like this:

Screenshot 1403-06-05 at 11 20 43

This PR uses the regular expression u flag to support Unicode characters. The result is now correct:

Screenshot 1403-06-05 at 11 23 47

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10555877509

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.977%

Totals Coverage Status
Change from base Build 10387601521: 0.0%
Covered Lines: 1549
Relevant Lines: 1666

💛 - Coveralls

@brendt brendt merged commit cbc3dc0 into tempestphp:main Aug 27, 2024
4 checks passed
@brendt
Copy link
Member

brendt commented Aug 27, 2024

Cool, thanks!

@brendt
Copy link
Member

brendt commented Aug 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants