Don't camel case service names in YAML. #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more intuitive to keep the YAML structure using kubernetes style naming.
yux0
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more intuitive to keep the YAML structure using kubernetes style naming.
What was changed
Stopped using camel case in the values YAML for services.
Why?
It's more intuitive that the names match between kubernetes and the values. This also simplifies code, at the cost of making it impossible to use dot notation for retrieval. I consider that a good trade off however, as that is only maintainer facing and will fail cleanly.
Checklist
Closes [Bug] Error retrieving settings when using internal-frontend #682
How was this tested:
Adjusted tests as required.
This replaces #683