Skip to content

friendlier unavailable connection error messages #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

friendlier unavailable connection error messages #2019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1bb097
friendlier unavailable connection error messages
kevinawoo Aug 14, 2025
a351b47
Merge branch 'master' into friendlier-unavailable-error-message
kevinawoo Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/internal_workflow_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,8 +1345,12 @@ func (wc *WorkflowClient) loadCapabilities(ctx context.Context) (*workflowservic
grpcCtx, cancel := newGRPCContext(ctx, grpcTimeout(wc.getSystemInfoTimeout))
defer cancel()
resp, err := wc.workflowService.GetSystemInfo(grpcCtx, &workflowservice.GetSystemInfoRequest{})
// We ignore unimplemented
if _, isUnimplemented := err.(*serviceerror.Unimplemented); err != nil && !isUnimplemented {
switch err.(type) {
case nil, *serviceerror.Unimplemented:
// We ignore unimplemented
case *serviceerror.Unavailable:
return nil, fmt.Errorf("%w. failed reaching server for namespace %s: ensure this namespace exists and your connection is configured correctly", err, wc.namespace)
default:
return nil, fmt.Errorf("failed reaching server: %w", err)
}
if resp != nil && resp.Capabilities != nil {
Expand Down
Loading