-
Notifications
You must be signed in to change notification settings - Fork 136
chore: support opentelemetry v2 #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@JackTreble Thanks for your work on this, that looks awesome. I'm a bit worried that this might be a breaking change for our users. Anything you can say about that? I suppose, for example, that users will need to simultaneously change their own code to also use OTel 2, and possibly also upgrade other OTel integration modules they have, right? Does OTel provide guidance for a smooth upgrade path? In any case, we'll need to cross that bridge at one point or another, so I'd consider merging this as part of our next minor release. In the mean time, I'll leave this PR pending. |
@mjameswh Cheers.
Yeah I think this change might be difficult to navigate, I think the best way forward could be be to retain support and add support for v2 in a separate package, allowing users to upgrade when best suits them. I might be worrying about nothing but is there a risk that introducing this change increases the minimum supported node and typescript versions of this library? I've not looked into what the minimum supported versions of the sdk are & how this minimum requirement in one module may affect the other modules so this might be a moot point. Minimum supported versions from release notes
The guidance on the repo is pretty comprehensive https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/upgrade-to-2.x.md |
Thoughts on supporting as two separate packages |
Two notes:
|
What was changed
Support OpenTelemetry v2
Why?
So the latest versions of OpenTelemetry are supported going forward
This was a fairly naive update libraries job using the upgrade docs as a guide and the otel tests to check behaviour.
If you're reading this months in the future feel free to take on this PR, I may forget to come back to it!
Checklist
Closes [Feature Request] Add support for opentelemetry v2 #1658
How was this tested: