Add Node 24 to CI test matrix #1762
Conversation
chris-olszewski
force-pushed
the
add-node-24
branch
from
c535787 to
5dbbedf
Compare
chris-olszewski
force-pushed
the
add-node-24
branch
from
5dbbedf to
c85562f
Compare
| "node_modules/nexus-rpc": { | ||
| "version": "0.0.1", | ||
| "resolved": "git+ssh://git@github.com/nexus-rpc/sdk-typescript.git#f594a7fd9e33bd14e5ce1ed04c5225fc708e7866", | ||
| "resolved": "https://registry.npmjs.org/nexus-rpc/-/nexus-rpc-0.0.1.tgz", |
There was a problem hiding this comment.
Switching from the git reference to the published package over the git one as NPM 11 has a breaking change which skips prepare scripts from running when --ignore-scripts is used. nexus-rpc needs prepare to produce lib/ files which are not checked in, but are present in the published package.
There was a problem hiding this comment.
Uhh? Actually the git-based dependency should have never been commited to main, not sure how come it slipped through. Replacing it with the published release is definitely the right thing to do.
chris-olszewski
force-pushed
the
add-node-24
branch
from
1673830 to
c87ea5f
Compare
| dedent` | ||
| ApplicationFailure: Fail me | ||
| at Function.nonRetryable (common/src/failure.ts) | ||
| at $CLASS.nonRetryable (common/src/failure.ts) |
There was a problem hiding this comment.
That comes out very neat. Great!
| 'Error' | ||
| ), | ||
| ], | ||
| [makeFailWorkflowExecution('Signal failed', 'Error')], |
There was a problem hiding this comment.
What if we kept the reference stack trace as argument to makeFailWorkflowExecution(), and instead did the special handling of stack traces as part of compareCompletion()? We'd simply iterate over history events, looking for WorkflowExecutionFailure events (if any). WDYT?
What was changed