[Nexus] Migrate registry and event definitions#9491
Open
gow wants to merge 6 commits intocg/nexus/history_events_registry_1from
Open
[Nexus] Migrate registry and event definitions#9491gow wants to merge 6 commits intocg/nexus/history_events_registry_1from
gow wants to merge 6 commits intocg/nexus/history_events_registry_1from
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
gow
changed the title
gow
force-pushed
the
cg/nexus/history_events_registry_2
branch
from
434044c to
5e9b49e
Compare
bergundy
reviewed
Mar 12, 2026
Comment on lines
+165
to
+166
| // We never cherry pick command events, and instead allow user logic to reschedule those commands. | ||
| return workflowregistry.ErrNotCherryPickable |
Member
There was a problem hiding this comment.
Let's see in the original HSM PR if this was considered not cherry pickable for a reason. I think it can be just as started and completed are.
Contributor
Author
There was a problem hiding this comment.
Here is the original PR - https://github.com/temporalio/temporal/pull/7564/changes#diff-ff80ea8912f318338bb15fcea05d631581cf7a1d1778b61333d3acfa0a7e4da0
Looks like it was a mistake. I have fixed the CherryPick() methods of all the events. Only ScheduledEventDefinition & CancelRequestedEventDefinition are not cherrypickable now.
Could you please check if the signature of Apply & CherryPick look ok?
Comment on lines
+212
to
+213
| // We never cherry pick command events, and instead allow user logic to reschedule those commands. | ||
| return workflowregistry.ErrNotCherryPickable |
Member
There was a problem hiding this comment.
Same here, it's not a command.
stephanos
reviewed
Mar 12, 2026
gow
force-pushed
the
cg/nexus/history_events_registry_1
branch
2 times, most recently
from
6509cde to
9c5b648
Compare
gow
force-pushed
the
cg/nexus/history_events_registry_2
branch
from
8744e61 to
f56cfa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Migrating Nexus history event Registry and Definition. I've also moved all the event implementations as well with commented out bodies. I will replace the implementations of
Apply()andCherryPick()in follow PRs.Depends on #9474
Why?
Migrating Nexus from HSM to CHASM.
How did you test it?
Note
Medium Risk
Introduces a new event-definition registry path that will be used during replication/reset/cherry-pick flows; current Nexus event handlers are registered but
Applylogic is stubbed to no-op, which could change behavior once these events are processed.Overview
Adds first-class history event support to the CHASM workflow
Registryby introducingEventDefinition,RegisterEventDefinition, and lookup/storage forEventTypehandlers alongside existing command handlers.Wires Nexus operations into this new mechanism by registering definitions for all Nexus operation history events (scheduled/cancel/start/complete/fail/cancel/timeout) via Fx, with placeholder
Applyimplementations and basic cherry-pick gating (skip command-like events and respectRESET_REAPPLY_EXCLUDE_TYPE_NEXUS).Written by Cursor Bugbot for commit f56cfa0. This will update automatically on new commits. Configure here.