Fix 9436 describe task queue stats#9521
Open
sachinsharma3191 wants to merge 2 commits intotemporalio:mainfrom
Open
Fix 9436 describe task queue stats#9521sachinsharma3191 wants to merge 2 commits intotemporalio:mainfrom
sachinsharma3191 wants to merge 2 commits intotemporalio:mainfrom
Conversation
Remove usage of github.com/pkg/errors and replace with standard library errors and fmt.Errorf wrapping. Changes: - common/finalizer/finalizer.go - service/worker/migration/activities.go - remove pkg/errors direct dependency via go mod tidy Addresses part of temporalio#9244 Made-with: Cursor
…#9436) Use GetReportStats() for consistent proto getter access in the legacy DescribeTaskQueue path, matching the enhanced mode implementation. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #9436 is implemented and pushed.
Changes
In service/matching/matching_engine.go, replaced req.ReportStats with req.GetReportStats() so the legacy path uses the protobuf getter, consistent with the enhanced path.
Branch
fix-9436-describe-task-queue-stats