Address dnr review comments on #9395#9539
Open
ShahabT wants to merge 1 commit intotemporalio:mainfrom
Open
Conversation
- Fix comment table alignment to use spaces instead of tabs - Simplify nil check in getCreateTime using proto getter - Rename runSuiteWithMatchingBehaviors to runTaskQueueStatsSuiteWithMatchingBehaviors - Remove redundant MatchingUseNewMatcher (already set in all functional tests) - Move MatchingForwarderMaxChildrenPerNode into matching behavior Options() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dnr
approved these changes
Mar 16, 2026
| func (b MatchingBehavior) Options() []TestOption { | ||
| var opts []TestOption | ||
| opts := []TestOption{ | ||
| WithDynamicConfig(dynamicconfig.MatchingForwarderMaxChildrenPerNode, 3), |
Contributor
There was a problem hiding this comment.
add this to https://github.com/temporalio/temporal/blob/main/tests/testcore/functional_test_base.go#L621 also (and we should consolidate those so there's only one copy of this logic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9395 addressing review comments:
getCreateTimeusing proto getter (handles nil receiver)runSuiteWithMatchingBehaviors→runTaskQueueStatsSuiteWithMatchingBehaviors(suite-specific)MatchingUseNewMatcherfrom test opts (already set globally in functional tests)MatchingForwarderMaxChildrenPerNodeintoMatchingBehavior.Options()Test plan
-tags test_dep🤖 Generated with Claude Code