fix(docs): remove defunct --disable-thread-pinning from bench README#2730
Open
HedgeQuantX wants to merge 1 commit intotempoxyz:mainfrom
Open
fix(docs): remove defunct --disable-thread-pinning from bench README#2730HedgeQuantX wants to merge 1 commit intotempoxyz:mainfrom
HedgeQuantX wants to merge 1 commit intotempoxyz:mainfrom
Conversation
The --disable-thread-pinning flag was removed from tempo-bench but the macOS example in the README still referenced it, causing confusion for new contributors trying to run benchmarks on macOS. Closes tempoxyz#1503
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--disable-thread-pinningflag was removed fromtempo-benchbut the macOS example in the README still referenced it, causing a confusing error for anyone following the docs on macOS.This removes the stale example. The benchmark now runs on macOS without any platform-specific flags.
Closes #1503