fix(chainspec): regenerate dev.json with v2 validator config#2746
Open
fix(chainspec): regenerate dev.json with v2 validator config#2746
Conversation
6f89bc0 to
eae7fd2
Compare
cd46b33 changed genesis initialization to use ValidatorConfigV2 when t2Time == 0, but dev.json was not regenerated. The embedded dev genesis still had v1 validator state at 0xCCCC...0000, causing --chain dev nodes to fail to produce blocks. Regenerated with: cargo x generate-genesis -o dev.json --accounts 10 --no-dkg-in-genesis Also updated the doc comment in spec.rs to match the correct command.
eae7fd2 to
542980e
Compare
howydev
approved these changes
Feb 17, 2026
SuperFluffy
requested changes
Feb 18, 2026
Contributor
SuperFluffy
left a comment
There was a problem hiding this comment.
This should probably take into account #2761
Unsure, but blocking just in case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in cd46b33 where
dev.jsonwas not regenerated after the validator config v2 genesis changes. The embedded dev genesis had v1 validator state at0xCCCC...0000, but witht2Time: 0the node expects v2 validators at0xCCCC...0001. This caused--chain devnodes to fail to produce blocks.Root Cause
cd46b33 changed genesis initialization to call
initialize_validator_config_v2whent2Time == 0, and updatedtest-genesis.jsonaccordingly, but forgot to regenerate the embeddeddev.json.Fix
Regenerated
dev.jsonwith:Testing
cargo test -p tempo-chainspec— 15/15 pass