feat(e2e): add tests for static DKG transitions with V1 -> V2 migrations#2750
Open
SuperFluffy wants to merge 5 commits intojanis/v2-peersetsfrom
Open
feat(e2e): add tests for static DKG transitions with V1 -> V2 migrations#2750SuperFluffy wants to merge 5 commits intojanis/v2-peersetsfrom
SuperFluffy wants to merge 5 commits intojanis/v2-peersetsfrom
Conversation
SuperFluffy
force-pushed
the
janis/v2-peersets-tests
branch
from
42258a6 to
6f53efd
Compare
SuperFluffy
commented
Feb 17, 2026
| Ok(rx) | ||
| } | ||
|
|
||
| pub(crate) async fn subscribe_finalized(&self, height: Height) -> eyre::Result<()> { |
Contributor
Author
There was a problem hiding this comment.
Added this to fix the issue of the peer actor wanting to read the finalized block before it was processed by the executor.
SuperFluffy
force-pushed
the
janis/v2-peersets-tests
branch
from
6f53efd to
bfe329f
Compare
SuperFluffy
commented
Feb 17, 2026
crates/e2e/src/lib.rs
Outdated
| // Still nice, because sometimes nodes can be better identified in logs. | ||
| let network_addresses = (1..) | ||
| .map(|port| SocketAddr::from(([127, 0, 0, 1], port))) | ||
| .map(|i| SocketAddr::from(([127, 0, 0, i], 8000))) |
Contributor
Author
There was a problem hiding this comment.
Addresses are now uniquely owned by validators (port doesn't matter).
SuperFluffy
force-pushed
the
janis/v2-peersets-tests
branch
2 times, most recently
from
eb9ec4f to
766709e
Compare
SuperFluffy
force-pushed
the
janis/v2-peersets-tests
branch
5 times, most recently
from
6c8f99d to
41e5882
Compare
SuperFluffy
force-pushed
the
janis/v2-peersets-tests
branch
from
41e5882 to
3e58511
Compare
SuperFluffy
requested review from
0xKitsune,
0xrusowsky,
fgimenez,
howydev,
klkvr,
legion2002 and
mattsse
as code owners
📊 Tempo Precompiles Coverage |
SuperFluffy
commented
Feb 20, 2026
| output: Read::read_cfg(buf, cfg)?, | ||
| share: ReadExt::read(buf)?, | ||
| players: Read::read_cfg(buf, &(range_cfg, ()))?, | ||
| syncers: Read::read_cfg(buf, &(range_cfg, ()))?, |
Contributor
Author
There was a problem hiding this comment.
Once transitioned to V2, syncers can be 0.
This is not a format breaking change! The RangeCfg acts as a check for the encoded length.
Of course once a node has transitioned to V2 it can no longer run in V1. But that's ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for DKG scenarios that involve a static set of validators and have a transition from the V1 to V2 validator configs.
Also adds a mechanism to wait for the executor to send a finalized block at a given height to the execution layer - this is to fix the problem of the peer manager attempting to read EL state before the block was submitted to the EL.