feat: lower default time-to-build-proposal from 500ms to 200ms#2787
Draft
feat: lower default time-to-build-proposal from 500ms to 200ms#2787
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019c7729-c7d3-73ad-9748-d6f8cb27335a Co-authored-by: Amp <amp@ampcode.com>
shekhirin
added
C-enhancement
SuperFluffy
reviewed
Feb 20, 2026
| /// for the leader to enter the view, build and broadcast the proposal, and | ||
| /// have the other peers receive the proposal. | ||
| #[arg(long = "consensus.time-to-build-proposal", default_value = "500ms")] | ||
| #[arg(long = "consensus.time-to-build-proposal", default_value = "200ms")] |
Contributor
There was a problem hiding this comment.
What worries me is the effect that this might have on subblocks (see below).
We only give it 100ms. While 100ms < 200ms this probably means that subblocks would only land under optimal network conditions and with virtually no clock drift.
SuperFluffy
force-pushed
the
alexey/lower-build-proposal-deadline
branch
from
fbf0e8d to
47f1aa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower the default
--consensus.time-to-build-proposalfrom 500ms to 200ms.Prompted by: alexey