test(account-keychain): add integration test for TEMPO-KEY21 tx_origin spending limit enforcement#2800
Open
bennytimz wants to merge 1 commit intotempoxyz:mainfrom
Open
test(account-keychain): add integration test for TEMPO-KEY21 tx_origin spending limit enforcement#2800bennytimz wants to merge 1 commit intotempoxyz:mainfrom
bennytimz wants to merge 1 commit intotempoxyz:mainfrom
Conversation
…n spending limit enforcement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an integration test for TEMPO-KEY21: spending limits are only consumed when
msg_sender == tx_origin.Why an integration test?
The
transaction_keyandtx_originvalues are set via transient storage (TSTORE/TLOAD) during real transaction execution. Foundry'svm.storecannot set transient storage, so this invariant cannot be verified in the existing Foundry invariant test suite (AccountKeychain.t.sol).A unit test already exists in
crates/precompiles/src/account_keychain/mod.rs(test_spending_limits_only_apply_to_tx_origin) but it mocksmsg_senderdirectly — it does not exercise the full transaction pipeline.What the test does
TIP20.transfer()internally (msg_sender = forwarder ≠ tx_origin)msg_sender = tx_origin)Files changed
crates/node/tests/it/account_keychain.rs— new test filecrates/node/tests/it/main.rs— module declaration added