Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced datadog agent with promtail #2053

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

pkrishnath
Copy link
Contributor

Why this change is needed

As part of our initiative to transition from Datadog to a more open-source solution, we are replacing the Datadog agent with Promtail, which is the preferred log collector for Loki. This will streamline our log aggregation process and improve integration with our existing Loki-based monitoring infrastructure.

What changes were made as part of this PR

manual-deploy-testnet-l2 workflow

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary solution to automate until we can get our CD tooling setup 🙏

I'd suggest we run a dev-testnet deployment with this before merging to make sure it works because hard to test GH actions any other way unfortunately.

target_label: 'job'
- replacement: ${HOSTNAME}
target_label: node_name
" > /home/obscuro/promtail/promtail-config.yaml \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work if /home/obscuro/promtail dir not been created yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@pkrishnath pkrishnath merged commit be1ad50 into ten-protocol:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants