Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event visibility config part 2 #2057

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

This is part 2 for #2056

Part 3 will follow shortly.

This change should not break existing functionality.

What changes were made as part of this PR

  • change the query logic to use the new configs
  • clarify and fix the event type and event topic storage logic

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bit easier to follow with those changes.

@tudor-malene tudor-malene merged commit 3e8c21f into main Sep 18, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/visibility_cfg_part2 branch September 18, 2024 12:31
@tudor-malene tudor-malene mentioned this pull request Sep 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants