Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve debug log relevancy #2075

Merged
merged 10 commits into from
Oct 16, 2024
Merged

improve debug log relevancy #2075

merged 10 commits into from
Oct 16, 2024

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

We want to expose the contract and event log visibility rules to dapp developers.

What changes were made as part of this PR

  • adjust the returned payload to reflect the latest changes
  • adjust the RPC signature to resemble "eth_getLogs", and enforce access control

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

google.golang.org/grpc v1.62.1
google.golang.org/protobuf v1.33.0
golang.org/x/sync v0.8.0
google.golang.org/grpc v1.67.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I regenerated the grpc stuff with the local tooling, and had to upgrade

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit 77d610e into main Oct 16, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/fix_debug_relevancy branch October 16, 2024 12:25
@tudor-malene tudor-malene mentioned this pull request Oct 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants