Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beacon process/ protodanksharding clean up tasks #2101

Merged
merged 15 commits into from
Oct 28, 2024
Merged

Beacon process/ protodanksharding clean up tasks #2101

merged 15 commits into from
Oct 28, 2024

Conversation

badgersrus
Copy link
Contributor

@badgersrus badgersrus commented Oct 21, 2024 •
edited
Loading

Why this change is needed

Clean up tasks following protodanksharding

What changes were made as part of this PR

  • Set the beacon URL based on enviroment during L2 deploy and upgrade
  • Kill the beacon processes last in eth2 network shutdown to remove flakiness
  • Switch CheckHostRPCServersStopped and StopEth2Network in Teardown function to remove flakiness
  • Increase tenscan first rollup timeout from 3 > 4mins as there appears to be intermittent failures on this

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@anixon604
Update manual-deploy-testnet-l1.yml
99d07d7 
add 12600 to vm security settings
@badgersrus badgersrus mentioned this pull request Oct 28, 2024
Closed
1 task
@badgersrus badgersrus changed the title beacon url for different envs Beacon process/ protodanksharding clean up tasks Oct 28, 2024
tudor-malene
tudor-malene approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@badgersrus badgersrus merged commit 46d94ae into main Oct 28, 2024
2 checks passed
@badgersrus badgersrus deleted the will/beacon-url-fix branch October 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tudor-malene tudor-malene tudor-malene approved these changes

@anixon604 anixon604 Awaiting requested review from anixon604

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badgersrus @tudor-malene @anixon604