Load system contract addresses on restart. #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
had a problem deploying
to
dev-testnet
GitHub Actions
Failure
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
had a problem deploying
to
dev-testnet
GitHub Actions
Failure
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
GitHub Actions
Inactive
StefanIliev545
had a problem deploying
to
dev-testnet
GitHub Actions
Failure
tudor-malene
approved these changes
Oct 27, 2024
| @@ -251,6 +251,11 @@ func NewEnclave( | |||
| logger.Crit("failed to resync L2 chain state DB after restart", log.ErrKey, err) | |||
| } | |||
|
|
|||
| err = scb.Load() | |||
| if err != nil && !errors.Is(err, errutil.ErrNotFound) { | |||
There was a problem hiding this comment.
do you handle not-found in any way?
There was a problem hiding this comment.
No, not found means db is there, but batches are not, which in turn means we havent bootstrapped yet with the first batches. Unless we delete them, but we should avoid pruning the first two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Load() method was not wired up meaning that restarts never managed to set the required addresses as the second batch that creates contracts is in the past.
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks