Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log file when starting Ten Gateway from launcher #2110

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Oct 28, 2024

Why this change is needed

For hosted gateway we use grafana and we have agents running which use std_out to get logs.
When stating the gateway from go run testnet/launcher/cmd we then have no way of getting logs for the gateway.

What changes were made as part of this PR

Changed log output from std_out to logfile.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@badgersrus badgersrus self-requested a review October 28, 2024 11:42
Copy link
Contributor

@badgersrus badgersrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zkokelj zkokelj merged commit b6e8b0f into main Oct 28, 2024
2 checks passed
@zkokelj zkokelj deleted the ziga/gateway_log_to_file_when_started_from_launcher branch October 28, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants