Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for PublicNode Sepolia Beaon APIs #2113

Merged
merged 11 commits into from
Nov 6, 2024
Merged

Conversation

badgersrus
Copy link
Contributor

@badgersrus badgersrus commented Oct 28, 2024

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

  • Removed duplicate declaration of rollup dups in validate_chain which might be the cause of intermittent failures on full sim
  • New unit test for sepolia blob providers but won't reliably pass because of blocks that dont contain blobs
  • Better error handling if the API returns empty array
  • Allow querying for all blobs in a block without providing the hash

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@badgersrus badgersrus merged commit 3ab664d into main Nov 6, 2024
2 checks passed
@badgersrus badgersrus deleted the will/sepolia-beacon-test branch November 6, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants