Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear responsibilities #2124

Merged
merged 1 commit into from
Nov 4, 2024
Merged

clear responsibilities #2124

merged 1 commit into from
Nov 4, 2024

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

In preparation for adding session keys, we need to clear responsibilities, because a lot of the services will be reused

What changes were made as part of this PR

  • move the "services" to a separate package
  • move all cache logic to its own package

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit d1b658a into main Nov 4, 2024
1 of 2 checks passed
@tudor-malene tudor-malene deleted the tudor/pre_sk_refactor branch November 4, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants