Skip to content

Commit

Permalink
feat: warn about envd v0 os and image usage (#1790)
Browse files Browse the repository at this point in the history
Signed-off-by: Keming <kemingyang@tensorchord.ai>
  • Loading branch information
kemingy authored Oct 24, 2023
1 parent 4482db0 commit 9027d35
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/lang/ir/v0/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package v0
import (
"github.com/cockroachdb/errors"
"github.com/opencontainers/go-digest"
"github.com/sirupsen/logrus"

"github.com/tensorchord/envd/pkg/editor/vscode"
"github.com/tensorchord/envd/pkg/lang/ir"
Expand All @@ -35,9 +36,13 @@ func Base(os, language, image string) error {
}
if len(os) > 0 {
g.OS = os
logrus.Warn("`os` only affects the GPU base image. If you want to use a different base image, " +
"envd v1 has better support. Check the doc https://envd.tensorchord.ai/guide/v1.html")
}
if image != "" {
g.Image = &image
logrus.Warn("Custom base image can only be used in non-dev env for envd v0. " +
"For better custom image support, check the envd v1 doc https://envd.tensorchord.ai/guide/v1.html")
}
return nil
}
Expand Down

0 comments on commit 9027d35

Please sign in to comment.