Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how the slice is stringified so it is easier to read. #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change how the slice is stringified so it is easier to read. #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
## Bug Fixes and Other Changes

## Breaking Changes
* Changes how cross-slice is stringified for easier read: "FeatureA:ValueA__XX__FeatureB:ValueB" to "FeautreA=ValueA Vs.
FeatureB=ValueB".

## Deprecations

Expand Down
5 changes: 2 additions & 3 deletions fairness_indicators/example_model_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import six
import tensorflow.compat.v1 as tf
import tensorflow_model_analysis as tfma
from tensorflow_model_analysis.slicer import slicer_lib as slicer

tf.compat.v1.enable_eager_execution()

Expand Down Expand Up @@ -96,7 +95,7 @@ def test_example_model(self):
FEATURE_MAP)

expected_slice_keys = [
'Overall', 'slice:slice3', 'slice:slice1', 'slice:slice2'
'Overall', 'slice: slice3', 'slice: slice1', 'slice: slice2'
]
evaluation_results = tfma.load_eval_result(tfma_eval_result_path)

Expand All @@ -105,7 +104,7 @@ def test_example_model(self):
# Verify if false_positive_rate metrics are computed for all values of
# slice.
for (slice_key, metric_value) in evaluation_results.slicing_metrics:
slice_key = slicer.stringify_slice_key(slice_key)
slice_key = tfma.slicer.stringify_slice_key(slice_key)
self.assertIn(slice_key, expected_slice_keys)
self.assertGreaterEqual(
1.0, metric_value['']['']
Expand Down