add ConfidenceInterval field

PiperOrigin-RevId: 386521367
tensorflow · Jul 23, 2021 · 101bac0 · 101bac0
1 parent ee4fff7
commit 101bac0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/model_card_toolkit/utils/graphics.py b/model_card_toolkit/utils/graphics.py
@@ -17,7 +17,7 @@
 import base64
 import io
 import logging
-from typing import Any, Sequence, Text, Tuple, Union, Optional
+from typing import Sequence, Text, Tuple, Union, Optional
 
 import attr
 import matplotlib
@@ -96,7 +96,6 @@ def annotate_eval_result_plots(model_card: model_card_module.ModelCard,
     eval_result: a `tfma.EvalResult`.
   """
 
-  # TODO(b/159058592): replace with `metrics = eval_result.get_metrics()`
   metrics = set()
   slices_keys = set()
   for slicing_metric in eval_result.slicing_metrics:
@@ -182,8 +181,7 @@ def _generate_graph_from_feature_statistics(
 
 
 def _generate_graph_from_slicing_metrics(
-    # TODO(b/159073391): replace Any with tfma.view.SlicedMetrics
-    slicing_metrics: Sequence[Any],
+    slicing_metrics: Sequence[tfma.view.SlicedMetrics],
     metric: Text,
     slices_key: Text = '',
     output_name: Text = '',

diff --git a/model_card_toolkit/utils/json_util.py b/model_card_toolkit/utils/json_util.py
@@ -46,6 +46,7 @@ def update(json_dict: Optional[Dict[Text, Any]] = None) -> Dict[Text, Any]:
     logging.info("JSON object already matches schema 0.0.2.")
     return json_dict  # pytype: disable=bad-return-type
   except jsonschema.ValidationError:
+    logging.info("JSON object does match schema 0.0.2; updating.")
     return _update_from_v1_to_v2(json_dict)