Fix Keras 3.x compatibility in FactorizedTopK layer #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The add_weight() method call in Streaming.init used positional
arguments which breaks with Keras 3.x. Changed to keyword argument to maintain compatibility with both Keras 2.x and 3.x versions.
Fixes users getting "Cannot convert ('c','o','u','n','t','e','r') to
a shape" error when using TensorFlow 2.16+ with TFRS 0.7.3.
Fixes tensorflow#712
Fixes tensorflow#731
Fixes tensorflow#748
Fixes tensorflow#754
Fixes tensorflow#759
|
When can we expect this pull request to be completed? At the moment, the TensorFlow recommenders tutorials won't work with any |
|
Hello, I fixed internally via #765 (same PR as yours). |
|
#765 which merged should have this fixed. Sadly, there's no autoclose of this and duplicates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add_weight() method call in Streaming.init used positional arguments which breaks with Keras 3.x. Changed to keyword argument to maintain compatibility with both Keras 2.x and 3.x versions.
Fixes users getting "Cannot convert ('c','o','u','n','t','e','r') to a shape" error when using TensorFlow 2.16+ with TFRS 0.7.3.
Fixes #712
Fixes #731
Fixes #748
Fixes #754
Fixes #759