Fix flaky "New Card Pinned" behavior. #6708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
changed the title
rileyajones
reviewed
Dec 21, 2023
| @@ -51,5 +51,5 @@ import {CardIdWithMetadata} from '../metrics_view_types'; | |||
| export class PinnedViewComponent { | |||
| @Input() cardObserver!: CardObserver; | |||
| @Input() cardIdsWithMetadata!: CardIdWithMetadata[]; | |||
| @Input() newCardPinnedIds!: [number]; | |||
| @Input() lastPinnedCardTime!: [number]; | |||
There was a problem hiding this comment.
Does this still need to be a [number]? It seems simpler to be number
rileyajones
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the behavior for showing the "New Card Pinned" notice is flaky. It sometimes does not trigger for the first pinned card after page load.
We just simplify the logic by tracking the "lastPinnedCardTime" in ngrx state and deriving the "New Pinned Card" notice from that state.