Deprecate KFP v1 SDK support #6924
Open
+54
−3,917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briron
reviewed
Oct 4, 2024
There was a problem hiding this comment.
It is probably not related to this PR, but the test tests (3.10, not e2e, DEFAULT) is failing in this PR because of KEYERROR, and _BASE_CONTAINER_IMAGE = os.environ['KFP_E2E_BASE_CONTAINER_IMAGE'] seems to be a culprint of the failure.
There was a problem hiding this comment.
I think we should update some CI settings and/or some test utility files. Since py_test collects non-e2e tests at runtime, the unit tests are complaining that there are no valid environments.
cc: @peytondmurray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New TFX version discontinues KFP v1 SDK support.