Skip to content

Conversation

@teociaps
Copy link
Owner

@teociaps teociaps commented Mar 1, 2025

Documentation Update:

  • README.md: Updated the project title with an emoji and made minor changes to the example configurations.

Dependency Update:

  • package.json: Updated the @octokit/rest dependency version from ^21.1.0 to ^21.1.1.

Chart Component Enhancements:

  • src/chart/components/bubbles.ts: Added a new function processBubbleNodes to handle bubble node processing, including creating bubble elements and generating styles.
  • src/chart/components/legend.ts: Introduced a new function createLegend to generate the legend for the bubble chart, including preparing legend items and grouping them into rows.
  • src/chart/components/title.ts: Added a new function createTitleElement to generate the title element for the chart, including handling text wrapping and style generation.

Chart Generator Refactor:

  • src/chart/generator.ts: Refactored the chart generation process by integrating the new component functions (processBubbleNodes, createLegend, and createTitleElement) and improving the overall structure and error handling.

@teociaps teociaps self-assigned this Mar 1, 2025
@vercel
Copy link

vercel bot commented Mar 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-bubble-chart ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 3:59pm

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Related to a dependency file labels Mar 1, 2025
@codecov
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 96.04396% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/chart/components/legend.ts 93.63% 7 Missing ⚠️
src/chart/components/bubbles.ts 93.33% 6 Missing ⚠️
src/chart/components/title.ts 95.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@teociaps teociaps merged commit a508ea6 into main Mar 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related to a dependency file documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant