Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved SyntaxErrorTests from pth-10 #79

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Abigael-JT
Copy link
Contributor

@Abigael-JT Abigael-JT commented Sep 19, 2024

Added LogicalOperationSyntaxTests and a disabled syntax test for missing quotes in a field because it did not throw an exception while it should, issue: #76

Also added a test case for if statement

Related PR from pth-10: teragrep/pth_10#346

Related issue from pth-10: teragrep/pth_10#322

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@elliVM elliVM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Abigael-JT Abigael-JT requested a review from kortemik September 20, 2024 08:10
@kortemik kortemik merged commit 1269004 into teragrep:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants