Skip to content

Comments

bump(main/tree-sitter): 0.26.3 + revbumps#27694

Draft
TomJo2000 wants to merge 13 commits intotermux:masterfrom
TomJo2000:ts-0.26.x
Draft

bump(main/tree-sitter): 0.26.3 + revbumps#27694
TomJo2000 wants to merge 13 commits intotermux:masterfrom
TomJo2000:ts-0.26.x

Conversation

@TomJo2000
Copy link
Member

This PR updates tree-sitter to 0.26.3 and rebuilds the reverse dependencies.

I tried revbumping mogan but that build seems to be completely unsalvageable in its current state.
Upstream seems to have changed the versioning scheme and did some major refactoring to its build system.
I am not nearly familiar enough with Xmake to get either 1.2.9.8, or the latest stable release(2025.2.2)1 to build.
I have moved mogan to disabled-packages/ for now since it cannot be rebuilt and the tree-sitter SO version update will break the package for certain.

If someone else is able to get it updated and working the help would be very much appreciated.

Footnotes

  1. https://github.com/XmacsLabs/mogan/releases/latest

@TomJo2000
Copy link
Member Author

Don't know what that Emacs build failure is about.
tree-sitter is picked up correctly during the configure stage.

# [...]
Does Emacs use -ltree-sitter?                           yes
# [...]
checking for tree-sitter >= 0.20.2... yes
# [...]
  CC       treesit.o
  CC       itree.o
  CC       json.o
  CC       terminfo.o
  CC       lastfile.o
/home/builder/.termux-build/emacs/src/src/treesit.c:749:21: error: call to undeclared function 'ts_language_version'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  749 |                             make_fixnum (ts_language_version (lang)));
      |                                          ^
/home/builder/.termux-build/emacs/src/src/treesit.c:749:21: note: did you mean 'ts_language_abi_version'?
/data/data/com.termux/files/usr/include/tree_sitter/api.h:1249:10: note: 'ts_language_abi_version' declared here
 1249 | uint32_t ts_language_abi_version(const TSLanguage *self);
      |          ^
/home/builder/.termux-build/emacs/src/src/treesit.c:820:27: error: call to undeclared function 'ts_language_version'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  820 |       uint32_t version =  ts_language_version (ts_language);
      |                           ^
2 errors generated.
make[2]: *** [Makefile:457: treesit.o] Error 1
make[2]: *** Waiting for unfinished jobs....
1 warning generated.
make[2]: Leaving directory '/home/builder/.termux-build/emacs/build/src'
make[1]: *** [Makefile:554: src] Error 2
make[1]: Leaving directory '/home/builder/.termux-build/emacs/build'
make[1]: Entering directory '/home/builder/.termux-build/emacs/build'
***
*** "make all" failed with exit status 2.
***
*** You could try to:
*** - run "make bootstrap", which might fix the problem
*** - run "make V=1", which displays the full commands invoked by make,
***   to further investigate the problem
***
make[1]: *** [Makefile:418: advice-on-failure] Error 2
make[1]: Leaving directory '/home/builder/.termux-build/emacs/build'
make: *** [Makefile:374: all] Error 2

@TomJo2000
Copy link
Member Author

TomJo2000 commented Dec 21, 2025

Ah it looks like ts_language_version was deprecated in favor of ts_language_semantic_version.

I'm guessing that's causing the issue here.

Found the patch for it.
emacs-mirror/emacs@d587ce8

@TomJo2000
Copy link
Member Author

Neovim doesn't plan to support tree-sitter 0.26.x on the 0.11 release, so that will have to act as a blocker for updating tree-sitter until and unless another distro backports it, or Neovim 0.12 is released.

@TomJo2000 TomJo2000 marked this pull request as draft December 21, 2025 11:41
@robertkirkman
Copy link
Member

I could not recompile mogan, and I have reason to believe that it would not compile if bumped either, but could you skip editing mogan at all in this PR? It does not currently depend on tree-sitter.

@TomJo2000
Copy link
Member Author

I could not recompile mogan, and I have reason to believe that it would not compile if bumped either, but could you skip editing mogan at all in this PR? It does not currently depend on tree-sitter.

It doesn't directly depend on tree-sitter but it has plugins that do.
I can't get mogan building against NDK 29 as it currently is on master either.

@robertkirkman
Copy link
Member

What I mean is that neither mogan nor its plugins are currently built with tree-sitter in a way that would prevent them from working if tree-sitter were bumped without mogan being recompiled, or if mogan is installed without tree-sitter installed at all.

@robertkirkman robertkirkman linked an issue Jan 4, 2026 that may be closed by this pull request
@robertkirkman
Copy link
Member

After 1 month of trying I managed to recompile mogan successfully, though I don't know how to bump it to the newest version.

It will be possible to recompile in order to test it with any tree-sitter-related changes after this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto update failing for tree-sitter

2 participants