Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape and Ctrl+Alt keys in user action section #667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knyipab
Copy link
Contributor

@knyipab knyipab commented Jul 4, 2024

See if this looks good to you. Feel free to change. Thanks.

Btw, I thought of changing the name of "Pause key intercepting with Esc key" option cuz that's not so accurate. Indeed, any gestures/keys/buttons that release pointer will be affected by this option. Probably it's better to remove this option, and then add "release pointer" to userActionsValues, so to distinguish from "release pointer and keyboard capture". That involes more changes to the code base, so I didn't implement and leave it to your decision.

@knyipab

This comment was marked as outdated.

@knyipab knyipab force-pushed the ctrl-alt-quit-capture branch from 2c17333 to 88791a8 Compare July 5, 2024 14:59
@knyipab
Copy link
Contributor Author

knyipab commented Jul 5, 2024

Rebased
Screenshot_20240705_230333_TermuxX11

@twaik
Copy link
Member

twaik commented Jul 7, 2024

I do not think it is a good idea to do things like this for key combinations. Probably it would be better to choose something like Host key (like in Virtualbox or VMWare Workstation) (and probably make it configurable, defaulting to right control) and implement additional key combinations for different actions (like toggling EK bar, fullscreen, other stuff.

@knyipab
Copy link
Contributor Author

knyipab commented Jul 8, 2024

Umm... I used only virt-manager and after looking at some screenshots, vmware workstation's model (any/combo of Ctrl, Shift, Alt and Meta as "host key") is probably easier to implement cuz Android natively provides isCtrlPressed(), isShiftPressed(), isAltPressed() and isMetaPressed(), so the current PR code logic won't need to change substantially. User can add entries of Host key + any additional key (though need to figure out how to do such variable-sized config layout & storage). Lastly, "Escape key" will remain to be a separate item in this preference page. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants