Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for service connect tls settings #216

Merged

Conversation

kevouellet
Copy link

Description

Adds support for tls under service_connect_configuration.service. Within tls, you can specify issuer_cert_authority, kms_key and role_arn. Those fields are documented here.

Motivation and Context

This change allows the user to enable TLS and encrypt Service Connect traffic. The default settings are not adequate for all use cases.

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

No examples were appended due to the nature of the TLS configuration requiring an AWS Certificate Manager Private Certificate Authority. If you feel this should be implemented in one of the examples anyway, let me know.

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 8774416 into terraform-aws-modules:wip/v6 Aug 5, 2024
2 checks passed
Copy link

github-actions bot commented Sep 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants