fix: Incorrect VPC selection for Security group introduced in #353 #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahorniak
changed the title
3 tasks
bryantbiggs
reviewed
Oct 2, 2025
|
|
||
| data "aws_subnet" "this" { | ||
| count = local.create_security_group && var.vpc_id != null ? 1 : 0 | ||
| count = local.create_security_group ? 1 : 0 |
There was a problem hiding this comment.
this is incorrect - it should be
Suggested change
| count = local.create_security_group ? 1 : 0 | |
| count = local.create_security_group && var.vpc_id == null ? 1 : 0 |
There was a problem hiding this comment.
@bryantbiggs, with the suggested code, the Terraform plan is failing on example/complete. I tried this as well, but it didn't work, and I decided not to investigate further why it's not working.
│ Error: Invalid count argument
│
│ on ../../modules/service/main.tf line 1641, in data "aws_subnet" "this":
│ 1641: count = local.create_security_group && var.vpc_id == null ? 1 : 0
│
│ The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many
│ instances will be created. To work around this, use the -target argument to first apply only the resources that the count
│ depends on.
bryantbiggs
reviewed
Oct 2, 2025
| name_prefix = var.security_group_use_name_prefix ? "${local.security_group_name}-" : null | ||
| description = var.security_group_description | ||
| vpc_id = try(data.aws_subnet.this[0].vpc_id, var.vpc_id) | ||
| vpc_id = coalesce(var.vpc_id, data.aws_subnet.this[0].vpc_id) |
There was a problem hiding this comment.
this is incorrect - it has the potential to fail
There was a problem hiding this comment.
@bryantbiggs, do you have any ideas on how to prevent this?
|
This issue has been resolved in version 6.6.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect VPC selection introduced in #353
Motivation and Context
Discussions can be found here and here
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request