Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add variable for disabling dynamic outputs #3209

Conversation

ajax-ryzhyi-r
Copy link

@ajax-ryzhyi-r ajax-ryzhyi-r commented Nov 18, 2024

Description

Add disable_dynamic_outputs variable for disabling outputs that can cause drifts

Motivation and Context

We use this module directly from terragrunt, and occasionally, configuration drift occurs due to changes in the cluster_platform_version and cluster_addons outputs. Since these changes are made on the AWS side, these drifts are false positives. It would be beneficial to have an option to disable them.

363097684-5a6b5e8c-b734-4a35-b473-221a08c8e44b
Screenshot 2024-11-14 at 08 58 50
Screenshot 2024-11-18 at 09 36 43

Breaking Changes

All changes are backward compatible

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

This is not valid - these are computed values and expected to change. Most likely this is a user configuration error

@ajax-ryzhyi-r
Copy link
Author

This is not valid - these are computed values and expected to change. Most likely this is a user configuration error

I understand that these values are expected to change, which is why we want to ignore them. As mentioned in the PR description, we're using this module directly from terragrunt, so changes in these outputs cause false-positive drifts.

Any chance of getting this merged?)

@bryantbiggs
Copy link
Member

Any chance of getting this merged?)

No - I don't see why this would cause any conflicts. if you don't use these outputs in your implementation, then don't specify them.

@ajax-ryzhyi-r
Copy link
Author

Any chance of getting this merged?)

No - I don't see why this would cause any conflicts. if you don't use these outputs in your implementation, then don't specify them.

We don't use these outputs but we can't disable them without modifying this module because we're using it directly from terragrunt, which turns this module into the root module

@bryantbiggs
Copy link
Member

I'm not a terragrunt user but that sounds like a terragrunt issue - @antonbabenko are you familiar with this behavior in terragrunt?

@antonbabenko
Copy link
Member

I agree that this is not a Terragrunt issue but rather the expected behavior of Terraform (it shows what has changed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants