Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding variable trusted_role_actions to other sub-modules #392

Closed
tcharewicz opened this issue Jun 20, 2023 · 3 comments · Fixed by #393
Closed

Feat: Adding variable trusted_role_actions to other sub-modules #392

tcharewicz opened this issue Jun 20, 2023 · 3 comments · Fixed by #393

Comments

@tcharewicz
Copy link
Contributor

Is your request related to a problem? Please describe.

Currently variable trusted_role_actions is only available at sub-module iam-assumable-role.

Describe the solution you'd like.

I'd like to have the same variable, in sub modules. For saml sub module default variable will be different.

  • iam-assumable-roles
  • iam-assumable-role-with-saml
  • iam-assumable-roles-with-saml

Describe alternatives you've considered.

None.

Additional context

It's useful to use two additional action with STS action:

  • sts:SetSourceIdentity
  • sts:TagSession

But when you want to use them, you need to add them to all roles in AWS Account.

@tcharewicz
Copy link
Contributor Author

PR #393

@antonbabenko
Copy link
Member

This issue has been resolved in version 5.23.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants