Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added variable trusted_role_actions to sub modules as a "Action of STS" #393

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

tcharewicz
Copy link
Contributor

@tcharewicz tcharewicz commented Jun 20, 2023

Description

Orginaly I create issue with "Adding variable trusted_role_actions to other sub-modules"
- iam-assumable-roles
- iam-assumable-role-with-saml
- iam-assumable-roles-with-saml

At the time of PR creation I found that, in sub module iam-assumable-role-with-saml this variable is used, but in different way comparing to sub module iam-assumable-role.

In module with iam-assumable-role-with-saml is used as a "Extra Actions of STS"

variable "trusted_role_actions" {
  description = "Extra Actions of STS"
  type        = list(string)
  default     = [""]
}

In module with iam-assumable-role is used as a "Actions of STS"

variable "trusted_role_actions" {
  description = "Actions of STS"
  type        = list(string)
  default     = ["sts:AssumeRole"]
}

That way finally PR is adding this variable as a "Extra Actions of STS" to sub modules:

  • iam-assumable-role
  • iam-assumable-roles
  • iam-assumable-roles-with-saml

Motivation and Context

It's useful to use two additional action with STS action:

sts:SetSourceIdentity
sts:TagSession

But when you want to use them, you need to add them to all roles in AWS Account.

Breaking Changes

None, all orginal default action are preserved.

How Has This Been Tested?

  • [yes] I have executed pre-commit run -a on my pull request

@tcharewicz tcharewicz changed the title feat: added variable trusted_role_actions to sub modules as a Extra action of STS feat: Added variable trusted_role_actions to sub modules as a Extra action of STS Jun 20, 2023
@tcharewicz tcharewicz changed the title feat: Added variable trusted_role_actions to sub modules as a Extra action of STS feat: Added variable trusted_role_actions to sub modules as a "Action of STS" Jun 27, 2023
@bryantbiggs bryantbiggs merged commit 5702679 into terraform-aws-modules:master Jun 29, 2023
35 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 29, 2023
## [5.23.0](v5.22.0...v5.23.0) (2023-06-29)

### Features

* Added variable trusted_role_actions to sub modules as a "Action of STS" ([#393](#393)) ([5702679](5702679))
@antonbabenko
Copy link
Member

This PR is included in version 5.23.0 🎉

@tcharewicz
Copy link
Contributor Author

@bryantbiggs Thx.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Adding variable trusted_role_actions to other sub-modules
3 participants