Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam-assumable-role-with-oidc): Add assume role policies #380

Closed
wants to merge 5 commits into from
Closed

feat(iam-assumable-role-with-oidc): Add assume role policies #380

wants to merge 5 commits into from
+22 −3

Conversation

awoimbee
Copy link

Description

Enable users to set source_policy_documents on the assume role policy.

Motivation and Context

Fixes #361.

As I'm creating IAM OIDC roles, I need to be able to test them by assuming them. Using source_policies is the most generic implem, so other use cases might also benefit this.

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@awoimbee awoimbee changed the title IAM OIDC role: add assume role policies feat(iam-assumable-role-with-oidc): add assume role policies May 16, 2023
@awoimbee awoimbee changed the title feat(iam-assumable-role-with-oidc): add assume role policies feat: add assume role policies to iam-assumable-role-with-oidc May 16, 2023
@awoimbee awoimbee changed the title feat: add assume role policies to iam-assumable-role-with-oidc feat(iam-assumable-role-with-oidc): Add assume role policies May 16, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 16, 2023
@awoimbee
Copy link
Author

:'(

@antonbabenko
Copy link
Member

@awoimbee The code looks good. Please rebase it and let me know. I will merge it.

@awoimbee awoimbee force-pushed the iam-oidc-role-add-assume-role-policies branch from c3e6e03 to b1ce002 Compare June 16, 2023 11:54
@awoimbee
Copy link
Author

Thanks @antonbabenko , done

@antonbabenko
Copy link
Member

Please fix the failing CI checks, too.

@github-actions github-actions bot removed the stale label Jun 17, 2023
@awoimbee awoimbee force-pushed the iam-oidc-role-add-assume-role-policies branch from c5def33 to 52a7c1e Compare June 29, 2023 13:06
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 31, 2023
@awoimbee awoimbee force-pushed the iam-oidc-role-add-assume-role-policies branch from 4011793 to 164595b Compare August 2, 2023 08:51
@github-actions github-actions bot removed the stale label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Sep 3, 2023
@awoimbee
Copy link
Author

awoimbee commented Sep 3, 2023

Bad bot
I spent too much time fighting the damn commit hooks to not merge this PR !

@github-actions github-actions bot removed the stale label Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 4, 2023
@awoimbee awoimbee force-pushed the iam-oidc-role-add-assume-role-policies branch from 164595b to 59f774f Compare October 4, 2023 09:06
@github-actions github-actions bot removed the stale label Oct 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 5, 2023
@github-actions GitHub Actions
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Nov 16, 2023
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iam-assumable-role-with-oidc] Allow addition of custom assume role rules
2 participants
@awoimbee @antonbabenko