-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add required S3 PutObjectTagging permission to Velero IRSA policy #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! If you want to add the same change here https://github.com/terraform-aws-modules/terraform-aws-eks-pod-identity that would be greatly appreciated!
## [5.44.2](v5.44.1...v5.44.2) (2024-10-01) ### Bug Fixes * Add required S3 PutObjectTagging permission to Velero IRSA policy ([#517](#517)) ([f0e65a7](f0e65a7))
This PR is included in version 5.44.2 🎉 |
@bryantbiggs Here's the PR for |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adds required
s3:PutObjectTagging
permission to Velero IRSA policyMotivation and Context
Resolves #518
Breaking Changes
No
How Has This Been Tested?
Probably a bit overkill, but the following steps show not only how to reproduce the behavior, but also how this PR resolves the issue:
Clone https://github.com/chrisRedwine/velero-mre, which contains the minimal reproducible example for the issue.
Run
tofu init
andtofu apply
to create and configure the required resources (VPC, EKS, EBS CSI driver, Snapshot Controller, Velero, Pod w/ PVC and data, etc.).Wait until everything is set up and the
ebs-pvc-pod
has run and saved data to the volume.Run
velero backup create ebs-test-broken --include-namespaces=default --snapshot-move-data
.See the error in the logs described below, and note that
velero backup describe ebs-test-broken
shows the backup failed.Switch the
use_fixed_velero_policy
variable interraform.tfvars
totrue
in thechrisRedwine/velero-mre
repo.Run
tofu apply
Wait for the 3
velero
pods to restart so that they use the fixed IRSA.Run
velero backup create ebs-test-fixed --include-namespaces=default --snapshot-move-data
.Notice no errors in the logs, and that
velero backup describe ebs-test-fixed
shows the backup succeeded.(Make sure to clean up with
tofu destroy
afterwards)I have updated at least one of the
examples/*
to demonstrate and validate my change(s)I have tested and validated these changes using one or more of the provided
examples/*
projectspre-commit run -a
on my pull request