Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure IRSA for EKS FSX can Update File Systems #520

Conversation

kamirendawkins
Copy link
Contributor

@kamirendawkins kamirendawkins commented Sep 21, 2024

Description

Motivation and Context

Fixes #496, Re-Open of #497, Blocked by kubernetes-sigs/aws-fsx-csi-driver#394

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@kamirendawkins
Copy link
Contributor Author

@bryantbiggs kubernetes-sigs/aws-fsx-csi-driver#394 is now merged so I believe this should no longer be blocked.

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you - perhaps you'd be interested in applying the same change to https://github.com/terraform-aws-modules/terraform-aws-eks-pod-identity as well 😬

@bryantbiggs bryantbiggs merged commit b84b3c2 into terraform-aws-modules:master Sep 24, 2024
34 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 24, 2024
## [5.44.1](v5.44.0...v5.44.1) (2024-09-24)

### Bug Fixes

* Ensure IRSA for EKS FSX can Update File Systems ([#520](#520)) ([b84b3c2](b84b3c2))
@antonbabenko
Copy link
Member

This PR is included in version 5.44.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAM Role for Service Accounts in EKS FSX Policy does not allow for Volume Expansion
3 participants