feat: Support Multi Region Cluster Name argument #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
requested changes
Jan 6, 2025
modules/multi-region-cluster/main.tf
Outdated
| @@ -0,0 +1,21 @@ | |||
| resource "aws_memorydb_multi_region_cluster" "this" { | |||
There was a problem hiding this comment.
we should leave this sub-module out for now - we don't want to re-wrap just a single resource, it doesn't really provide any value. for now, I think the state of multi-region cluster would be this standalone resource plus multiple instantiations of the memorydb module
examples/multi-region/main.tf
Outdated
| @@ -0,0 +1,237 @@ | |||
| provider "aws" { | |||
There was a problem hiding this comment.
lets leave out this example for now as well
magreenbaum
changed the title
bryantbiggs
approved these changes
Jan 7, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Jan 7, 2025
## [2.3.0](v2.2.0...v2.3.0) (2025-01-07) ### Features * Support Multi Region Cluster Name argument ([#12](#12)) ([1a7c7ce](1a7c7ce))
|
This PR is included in version 2.3.0 🎉 |
|
@antonbabenko : Can you please advise, when this version will be available on Terraform registry ? As currently it shows 2.2.0 as the latest 
|
|
@shiv4nsh Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support multi-region memorydb cluster name argument.
Motivation and Context
multi_region_clusterresource hashicorp/terraform-provider-aws#40376Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request