Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module): add cloudbuild connection module #312

Merged
merged 25 commits into from
Aug 22, 2024
Merged

feat(module): add cloudbuild connection module #312

merged 25 commits into from
Aug 22, 2024

Conversation

caetano-colin
Copy link
Member

@caetano-colin caetano-colin commented Aug 16, 2024 •
edited
Loading

This PR will add the module cloudbuild_repo_connection.

This module is designed to create and manage secret versions, as well as configure the necessary permissions for cloud build service agent when utilizing Cloud Build repositories (2nd generation).

Additionally, it will establish the corresponding Cloud Build repositories based on the cloudbuild_repos variable, where users can specify the repository names and URLs from their version control systems.

Users will provide the required secrets through the credential_config variable, indicating their chosen Git provider. Currently, the module supports both GitHub and GitLab.

@caetano-colin caetano-colin changed the title DRAFT: add connection module DRAFT: feat(module): add cloudbuild connection module Aug 16, 2024
@caetano-colin
Copy link
Member Author

/gcbrun

1 similar comment
@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@caetano-colin caetano-colin changed the title DRAFT: feat(module): add cloudbuild connection module feat(module): add cloudbuild connection module Aug 20, 2024
@caetano-colin caetano-colin marked this pull request as ready for review August 20, 2024 14:14
@caetano-colin caetano-colin requested a review from a team as a code owner August 20, 2024 14:14
apeabody
apeabody requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caetano-colin! A few minor things I noted during the final review.

examples/cloudbuild_repo_connection_gitlab/main.tf Show resolved Hide resolved
test/integration/cloudbuild_repo_connection_gitlab/cloudbuild_repo_connection_gitlab_test.go Outdated Show resolved Hide resolved
test/integration/cloudbuild_repo_connection_github/cloudbuild_repo_connection_github_test.go Outdated Show resolved Hide resolved
@apeabody apeabody requested a review from gtsorbo August 20, 2024 20:27
@caetano-colin
Copy link
Member Author

@apeabody thank you for the review! I implemented the requested changes. Regarding the module registry version I put:

version = "~> 9.0"

I'm assuming that would be the module version, If that is not correct please let me know.

@apeabody
Copy link
Contributor

@apeabody thank you for the review! I implemented the requested changes. Regarding the module registry version I put:

version = "~> 9.0"

I'm assuming that would be the module version, If that is not correct please let me know.

Yeah, that should be fine for now. Thanks!

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

@caetano-colin - The last INT test didn't complete before timeout, might want to bump slightly: https://github.com/terraform-google-modules/terraform-google-bootstrap/blob/master/build/int.cloudbuild.yaml#L15

@apeabody
Copy link
Contributor

@gtsorbo do you want to review before merging?

@caetano-colin
Copy link
Member Author

@caetano-colin - The last INT test didn't complete before timeout, might want to bump slightly: https://github.com/terraform-google-modules/terraform-google-bootstrap/blob/master/build/int.cloudbuild.yaml#L15

Created a commit that increases the timeout in 10minutes

@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit daniel-cit self-requested a review August 22, 2024 18:02
daniel-cit
daniel-cit approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@daniel-cit daniel-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeabody apeabody merged commit f79bbc5 into terraform-google-modules:master Aug 22, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@daniel-cit daniel-cit daniel-cit approved these changes

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caetano-colin @daniel-cit @apeabody