fix(valkey): convert gcs_source string to list for uris attribute #337
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gcs_source variable is declared as string but needs to be converted to a list/set when passed to the uris attribute of google_memorystore_instance. Without this fix, terraform plan fails with: Error: Incorrect attribute value type - set of string required. This change splits the comma-separated string into a list and trims whitespace around each URI.
xaviermanachwebedia2
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
This was referenced Nov 28, 2025
bug(valkey): gcs_source parameter causes type mismatch - string passed to set(string) attribute
#338
Open
Collaborator
|
/gcbrun |
Collaborator
|
@xaviermanachwebedia2 can u also add in the description of gcs_source variable that multiple sources can be passed as comma separated values. |
Author
|
It's not my idea to split it with "," . This it already in the description of the variable ;) |
Collaborator
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcs_source variable is declared as string but needs to be converted to a list/set when passed to the uris attribute of google_memorystore_instance.
Without this fix, terraform plan fails with:
Error: Incorrect attribute value type - set of string required.
This change splits the comma-separated string into a list and trims whitespace around each URI.