-
Notifications
You must be signed in to change notification settings - Fork 473
feat: Add support for read pools in postgres #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
22c9f23 to
0e14063
Compare
|
@imrannayer thanks for the review, added for the additional |
|
/gcbrun |
|
@eidam failing with following error |
|
Weird, I was running make lint locally without errors I likely won’t get into this until eoy, anyone feel free to pick this up |
|
fixed in #777 |
|
read pool != connection pool, but i will reopen once i get around this again |
Cloud SQL for PostgreSQL read pools are GA now, adding a support creating a read replica as a read pool.
The
google_sql_database_instanceresource supports it already, the only difference is node_count andinstance_typeto beREAD_POOL_INSTANCE.