Fixing misleading comment in FuelHandler.swapCascade() (#1910)

terrapower · Sep 26, 2024 · 96a5c88 · 96a5c88
1 parent 727825f
commit 96a5c88
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/armi/physics/fuelCycle/fuelHandlers.py b/armi/physics/fuelCycle/fuelHandlers.py
@@ -885,6 +885,11 @@ def swapCascade(self, assemList):
         """
         Perform swaps on a list of assemblies.
 
+        Parameters
+        ----------
+        assemList: list
+            A list of assemblies to be shuffled.
+
         Notes
         -----
         [goingOut,inter1,inter2,goingIn]  will go to
@@ -899,16 +904,15 @@ def swapCascade(self, assemList):
         # first check for duplicates
         for assem in assemList:
             if assemList.count(assem) != 1:
-                runLog.extra("Warning: %s is in the cascade more than once!" % assem)
+                runLog.warning(f"{assem} is in the cascade more than once.")
 
-        # now swap.
+        # now swap
         levels = len(assemList)
         for level in range(levels - 1):
             if not assemList[level + 1]:
-                # If None in the cascade, just skip it. this will lead to slightly unintended shuffling if
-                # the user wasn't careful enough. Their problem.
-                runLog.extra(
-                    "Skipping level %d in the cascade because it is none" % (level + 1)
+                runLog.info(
+                    f"Skipping level {level + 1} in the cascade because it is None. Be careful, "
+                    "this might cause an unexpected shuffling order."
                 )
                 continue
             self.swapAssemblies(assemList[0], assemList[level + 1])