Skip to content

Removing commit msg checkbox from PR template#2078

Merged
john-science merged 2 commits intomainfrom
pr_form
Feb 10, 2025
Merged

Removing commit msg checkbox from PR template#2078
john-science merged 2 commits intomainfrom
pr_form

Conversation

@john-science
Copy link
Copy Markdown
Member

What is the change?

Removed one checkbox from the PR template:

Why is the change being made?

We have a squash-and-merge policy for ARMI PRs. So I don't care if you have some silly PR messages in the history of your feature branch.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Feb 7, 2025
Copy link
Copy Markdown
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you to rephrase the sentence I commented on to your liking. Approved!

Co-authored-by: Arrielle Opotowsky <c-aopotowsky@terrapower.com>
@john-science john-science merged commit dd8effe into main Feb 10, 2025
22 checks passed
@john-science john-science deleted the pr_form branch February 10, 2025 21:58
drewj-tp added a commit that referenced this pull request Mar 21, 2025
* main: (26 commits)
  Adding Requirements and QA to Docs (#2076)
  Applying expansion for material composition changes (#2077)
  Accounting for symmetry factor in `getMgFlux` (#2086)
  Solving test warnings (#2084)
  Accounting for parent symmetry in component flux calc (#2068)
  Improving HexBlock.rotate() docstring (#2083)
  Improving wetted perimeter calc for depletable components (#2067)
  Implementing more detailed `__lt__` for components. (#1882)
  Expanding allowable XS types to include lower case letters (#2069)
  Making sure SFPs have spatial grids (#2082)
  Removing silent overwrite of `shutil.copy` (#2081)
  Removing commit msg checkbox from PR template (#2078)
  Removing an unhelpful comment (#2079)
  Revamping Requirements (#2074)
  Ignoring Fluid density warning for Component Fluids (#2075)
  Update doc build to py313 (#2050)
  Fix out of date assumption on AZS IDs for "natural nuclides" (#2049)
  Making material modifications more robust against type errors (#2046)
  Fixing custom isotopics for Fluids (#2071)
  Loosening tolerance on HexGrid roughly equal check (#2058)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code/comment cleanup: Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants