Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing an unhelpful comment #2079

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Removing an unhelpful comment #2079

merged 1 commit into from
Feb 7, 2025

Conversation

john-science
Copy link
Member

@john-science john-science commented Feb 7, 2025 •
edited
Loading

What is the change?

Removing a comment.

Why is the change being made?

This comment line is so conversational and anecdotal, I don't think it has ever been useful to anyone.

This was pointed out to me by Chris here: #2006 (comment)

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added documentation Improvements or additions to documentation cleanup Code/comment cleanup: Low Priority labels Feb 7, 2025
@john-science john-science requested a review from keckler February 7, 2025 19:21
keckler
keckler approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment makes me laugh out loud, I am going to miss it!

@john-science john-science merged commit 1ff7f65 into main Feb 7, 2025
22 checks passed
@john-science john-science deleted the comment_cleanup branch February 7, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keckler keckler keckler approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @keckler