Deprecate DFIndexer #457
Merged
Deprecate DFIndexer #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it shows lots of commits, but its only 7 files changed thus far |
|
This PR deprecates DFIndexer, and is now ready for review. I'm not sure if needs to be rebased, as it shows all the Java branch changes for some reason. |
seanmacavaney
force-pushed
the
deprecate_dfindexer
branch
from
dc4e731
to
48b1244
Compare
|
rebased |
|
i want to reexecute the notebook without all the INFO log messages before committing |
|
I think this can be merged now |
seanmacavaney
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP deprecating DFIndexer:
Problems remaining