Feat/notification service #45

M3R1ttt · 2025-11-02T18:03:29Z

No description provided.

- 新增英文版插件化通知系统架构设计文档,详细说明系统架构和实现方案 - 包含核心组件说明:通知提供者接口、插件加载器、通知管理器、消息格式化器 - 提供完整的代码示例,包括配置管理扩展、交易执行器重构和Telegram服务适配 - 添加Slack插件包设计方案,包含包结构、配置选项和使用指南 - 详细说明环境变量配置和代码使用方法,便于开发者

M3R1ttt · 2025-11-02T18:05:45Z

Hello, I have integrated it into the application. If you encounter any unexpected errors, please contact me with the error details from wherever you are.

Copilot

Pull Request Overview

This PR refactors the notification system from a hardcoded Telegram-only implementation to a plugin-based architecture using the tracker-notification package. The changes remove direct Telegram dependencies and related CLI commands, replacing them with a unified notification service that supports multiple providers (Telegram and Slack).

Key Changes:

Introduced tracker-notification package dependency for managing multiple notification providers
Removed TelegramService, handleTelegramCommand, and related test files
Updated TradingExecutor to use the new SendNotification utility instead of TelegramService
Updated environment variable configuration to use NOTIFICATION_TELEGRAM_ENABLED and NOTIFICATION_SLACK_ENABLED

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/utils/notification-service.ts	New unified notification service that manages Telegram and Slack providers
src/services/trading-executor.ts	Refactored to use new notification service, removed ConfigManager and TelegramService dependencies
src/services/telegram-service.ts	Deleted - functionality moved to tracker-notification package
src/commands/telegram.ts	Deleted - telegram-test command removed
src/commands/index.ts	Removed handleTelegramCommand export
src/index.ts	Removed telegram-test CLI command
package.json	Added tracker-notification@^1.0.0 dependency
.env.example	Updated with new notification configuration variables
README_EN.md	Updated documentation to reflect notification service changes
docs/plugin-notification-system-*.md	New documentation files for plugin architecture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T12:38:49Z

src/utils/notification-service.ts

+      const telegramProvider = new TelegramNotificationProvider({
+        botToken: process.env.TELEGRAM_BOT_TOKEN || '123456:ABC-DEF',
+        chatId: process.env.TELEGRAM_CHAT_ID || '123456789',
+        parseMode: 'Markdown'
+      });
+      notifications.addProvider(telegramProvider);
+    }
+
+    if (process.env.NOTIFICATION_SLACK_ENABLED === 'true') {
+      const slackProvider = new SlackNotificationProvider({
+        botToken: process.env.SLACK_BOT_TOKEN || 'xoxb-test-token',
+        channelId: process.env.SLACK_CHANNEL_ID || 'C123456789',


Hardcoded fallback values for sensitive credentials (botToken and chatId) should not be used. If these environment variables are not set, the code should either throw an error or skip provider initialization rather than using placeholder values that could lead to unexpected behavior or security issues.

Suggested change

const telegramProvider = new TelegramNotificationProvider({

botToken: process.env.TELEGRAM_BOT_TOKEN || '123456:ABC-DEF',

chatId: process.env.TELEGRAM_CHAT_ID || '123456789',

parseMode: 'Markdown'

});

notifications.addProvider(telegramProvider);

}

if (process.env.NOTIFICATION_SLACK_ENABLED === 'true') {

const slackProvider = new SlackNotificationProvider({

botToken: process.env.SLACK_BOT_TOKEN || 'xoxb-test-token',

channelId: process.env.SLACK_CHANNEL_ID || 'C123456789',

if (!process.env.TELEGRAM_BOT_TOKEN || !process.env.TELEGRAM_CHAT_ID) {

throw new Error('TELEGRAM_BOT_TOKEN and TELEGRAM_CHAT_ID must be set in environment variables to enable Telegram notifications.');

}

const telegramProvider = new TelegramNotificationProvider({

botToken: process.env.TELEGRAM_BOT_TOKEN,

chatId: process.env.TELEGRAM_CHAT_ID,

parseMode: 'Markdown'

});

notifications.addProvider(telegramProvider);

}

if (process.env.NOTIFICATION_SLACK_ENABLED === 'true') {

if (!process.env.SLACK_BOT_TOKEN || !process.env.SLACK_CHANNEL_ID) {

throw new Error('SLACK_BOT_TOKEN and SLACK_CHANNEL_ID must be set in environment variables to enable Slack notifications.');

}

const slackProvider = new SlackNotificationProvider({

botToken: process.env.SLACK_BOT_TOKEN,

channelId: process.env.SLACK_CHANNEL_ID,

Copilot · 2025-11-04T12:38:49Z

src/utils/notification-service.ts

+      const slackProvider = new SlackNotificationProvider({
+        botToken: process.env.SLACK_BOT_TOKEN || 'xoxb-test-token',
+        channelId: process.env.SLACK_CHANNEL_ID || 'C123456789',


Similar to Telegram, hardcoded fallback values for Slack credentials should not be used. These placeholder tokens could cause silent failures or unintended message delivery.

Suggested change

const slackProvider = new SlackNotificationProvider({

botToken: process.env.SLACK_BOT_TOKEN || 'xoxb-test-token',

channelId: process.env.SLACK_CHANNEL_ID || 'C123456789',

if (!process.env.SLACK_CHANNEL_ID) {

throw new Error('SLACK_CHANNEL_ID environment variable must be set when Slack notifications are enabled.');

}

const slackProvider = new SlackNotificationProvider({

botToken: process.env.SLACK_BOT_TOKEN || 'xoxb-test-token',

channelId: process.env.SLACK_CHANNEL_ID,

Copilot · 2025-11-04T12:38:50Z

src/utils/notification-service.ts

+      console.log('\n🎉 Stop order notification sent successfully!');
+    }
+
+


[nitpick] Extra blank line before the catch block (line 36) should be removed for consistency with standard TypeScript formatting.

Suggested change

Copilot · 2025-11-04T12:38:50Z

src/services/trading-executor.ts

-  private configManager: ConfigManager;


  constructor(apiKey?: string, apiSecret?: string, testnet?: boolean, configManager?: ConfigManager) {


The constructor still accepts a 'configManager' parameter but it's no longer used or stored. This unused parameter should be removed from the constructor signature to avoid confusion.

Suggested change

constructor(apiKey?: string, apiSecret?: string, testnet?: boolean, configManager?: ConfigManager) {

constructor(apiKey?: string, apiSecret?: string, testnet?: boolean) {

Copilot · 2025-11-04T12:38:51Z

package.json

@@ -36,6 +36,7 @@
    "fs-extra": "^11.3.2",
    "node-telegram-bot-api": "^0.66.0",
    "querystring": "^0.2.1",


[nitpick] The new 'tracker-notification' dependency should be documented. Consider adding a comment in package.json or ensuring the README includes information about what this package provides and where to find its source/documentation.

Suggested change

"querystring": "^0.2.1",

"querystring": "^0.2.1",

"_comment-tracker-notification": "Provides notification utilities for tracker events. See https://github.com/your-org/tracker-notification for source and documentation.",

Copilot · 2025-11-04T12:38:51Z

.env.example

+TELEGRAM_BOT_TOKEN=telegram_token
+TELEGRAM_CHAT_ID=telegram_chat_id


[nitpick] The example values 'telegram_token' and 'telegram_chat_id' are not realistic placeholders. Consider using more descriptive placeholder formats like '<your_telegram_bot_token>' or 'YOUR_BOT_TOKEN_HERE' to make it clearer that these need to be replaced with actual values.

Suggested change

TELEGRAM_BOT_TOKEN=telegram_token

TELEGRAM_CHAT_ID=telegram_chat_id

TELEGRAM_BOT_TOKEN=<your_telegram_bot_token>

TELEGRAM_CHAT_ID=<your_telegram_chat_id>

Copilot · 2025-11-04T12:38:51Z

.env.example

+# Bot Token: Create Slack App at https://api.slack.com/apps
+# Channel ID: Right-click channel → "Copy link" → extract ID from URL
+SLACK_BOT_TOKEN=xoxb-1234
+SLACK_CHANNEL_ID="#new-channel"


The example shows a channel name format ('#new-channel') but the code expects a channel ID (like 'C123456789'). This mismatch could confuse users. The example should use a proper channel ID format or the documentation should clarify the difference.

Suggested change

SLACK_CHANNEL_ID="#new-channel"

SLACK_CHANNEL_ID="C1234567890"

danimirpetrakov16-byte

BotНub

nick and others added 2 commits November 2, 2025 20:06

feat: notification service added

c9ee52a

terryso requested a review from Copilot November 4, 2025 12:36

Copilot AI reviewed Nov 4, 2025

View reviewed changes

danimirpetrakov16-byte reviewed Nov 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/notification service #45

Feat/notification service #45

Uh oh!

M3R1ttt commented Nov 2, 2025

Uh oh!

M3R1ttt commented Nov 2, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

danimirpetrakov16-byte left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		console.log('\n🎉 Stop order notification sent successfully!');
		}

		private configManager: ConfigManager;


		constructor(apiKey?: string, apiSecret?: string, testnet?: boolean, configManager?: ConfigManager) {

	"querystring": "^0.2.1",
	"querystring": "^0.2.1",
	"_comment-tracker-notification": "Provides notification utilities for tracker events. See https://github.com/your-org/tracker-notification for source and documentation.",

		TELEGRAM_BOT_TOKEN=telegram_token
		TELEGRAM_CHAT_ID=telegram_chat_id

	SLACK_CHANNEL_ID="#new-channel"
	SLACK_CHANNEL_ID="C1234567890"

Feat/notification service #45

Are you sure you want to change the base?

Feat/notification service #45

Uh oh!

Conversation

M3R1ttt commented Nov 2, 2025

Uh oh!

M3R1ttt commented Nov 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

danimirpetrakov16-byte left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants