Allow sharing of the REPL #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+5
to
+21
| const base64UrlDecodeChars = {'-': '+', '_': '/', '.': '='}; | ||
| const base64UrlDecode = input => { | ||
| try { | ||
| return atob(input.replace(/[-_.]/g, c => base64UrlDecodeChars[c])); | ||
| } catch { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| const base64UrlEncodeChars = {'+': '-', '/': '_', '=': '.'}; | ||
| const base64UrlEncode = input => { | ||
| try { | ||
| return btoa(input).replace(/[+/=]/g, c => base64UrlEncodeChars[c]); | ||
| } catch { | ||
| return null; | ||
| } | ||
| } |
| // Quote property names | ||
| opts = opts.replace(/^\s*(\w+):/gm, '"$1":'); | ||
| return JSON.parse(opts); | ||
| } |
Contributor
There was a problem hiding this comment.
I see why this is something we need to do (avoiding a self xss and whatnot), however there are some Terser options that are regexps. For instance you can use /^_/ to select properties started with _ to mangle :/
There are a few options that take functions too (which would be a nightmare) so I'm not mentioning that part.
Contributor
There was a problem hiding this comment.
I think it's possible to avoid this by disabling sharing for options that include RegExps and functions. Then you can do eval freely, and only do JSON.parse in loadState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves and loads the current REPL state into the hash fragment, allow simple sharing. I've wanted this a few times when trying to demo different compression options.